NO-JIRA: Reverting case OOM score adjustment#30932
NO-JIRA: Reverting case OOM score adjustment#30932openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughRemoved a Ginkgo test case from the two-node topology tests that verified etcd OOM score adjustment behavior across control-plane nodes. The deletion includes the associated constants, command parsing logic, and per-node assertions for the expected Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Scheduling required tests: |
|
/lgtm |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-recovery-techpreview-3of3 |
|
@fonta-rh: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/46d0c2e0-282a-11f1-8155-9b6b8f8cb654-0 |
|
@kasturinarra: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
@kasturinarra I don't think we a full revert :) Just drop the [OCPFeatureGate:DualReplica] for now. You will need to move it out of the parent block though, so may it actually is just easier to revert. Up to you! :D |
I think i better revert and wait for the promotion to check my changes in and may be i feel that is better ? |
|
/retest |
|
/verified by @kasturinarra |
|
@kasturinarra: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse ack |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, fonta-rh, kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kasturinarra: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Reverting case based on the discussion here https://redhat-internal.slack.com/archives/C07ABRBBDK3/p1774378156314529?thread_ts=1774375299.856139&cid=C07ABRBBDK3